-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: inferred stream type #592
Changes from all commits
97b9762
406c430
194b3b5
c2a74bf
6b272ff
8696684
17ed4a3
63a6e16
5c00897
edd3cba
e8f94f8
e2759a5
547c262
9b03fb3
dd05188
6864ce5
c50bc48
a04daf9
a02cbef
40a4080
a2ddc5a
bc0b739
13e69e8
087f72a
10ecbce
2e15450
a49e7a7
7f18442
79df569
faabf3e
6f95499
c54171d
34fb11d
62d055d
5273356
a2a65a4
82eb475
5b5547f
9a66246
e9ad032
9c07d36
8cd29d3
a3eed63
62342af
13fa3e3
1593473
1ae06bf
abc38f3
3b67a68
1179dc1
aeae31c
337ab48
4d60639
33e1016
48f18d5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
# Deprecated Stream Type | ||
|
||
#### Why This Error Occurred | ||
|
||
The provided `stream-type` is deprecated. | ||
|
||
#### Possible Ways to Fix It | ||
|
||
If you are a viewer of this video there is not much you can do. The owner of the | ||
video will have to fix this issue. | ||
|
||
If you are the owner of this video, `stream-type` can now be inferred based on the `playback-id` and is | ||
no longer required. However, if you would still like to explicitly declare the `stream-type` (e.g. to | ||
avoid an initial render of the wrong UI), here are the recommended refactors: | ||
|
||
- `stream-type="ll-live"` - Replace with `stream-type="live"` (we will infer that the `playback-id` is low latency HLS) | ||
- `stream-type="live:dvr"` or `stream-type="ll-live:dvr"` - Refactor as `stream-type="live"` & `target-live-window="Infinity"` | ||
|
||
### Useful Links | ||
|
||
- [Mux Player Attributes](https://github.com/muxinc/elements/tree/main/packages/mux-player#attributes) | ||
- [Mux Player React Props](https://github.com/muxinc/elements/tree/main/packages/mux-player-react#props) | ||
- [Play your videos](https://docs.mux.com/guides/video/play-your-videos) |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -30,7 +30,6 @@ yarn add @mux/mux-player | |
playback-id="DS00Spx1CV902MCtPj5WknGlR102V5HFkDe" | ||
metadata-video-title="Big Buck Bunny" | ||
metadata-viewer-user-id="user-id-1234" | ||
stream-type="on-demand" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ooh yeah! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unless figuring out how to handle the pre-metadata loading UI is a blocker for this PR, I think we should probably keep documentation mentioning that stream-type is required. Also, I don't think it should be a blocker, this way, we can get this PR in good shape and merge and then allow us to figure out the UI stuff in a follow-up PR. |
||
></mux-player> | ||
``` | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(non-blocking) -- open to other opinions.
Can we put this on a branch for safe keeping? Feels weird to have it in the repo if it's never linked.
Might also want to put the commented code on a branch. Feels a little sloppy to have commented out code making it into
main