Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add startLevel prop to mux-video-react #772

Closed
wants to merge 1 commit into from

Conversation

staniwasd
Copy link

Hey team,

A small PR that allows you to add the startLevel prop in the MuxVideo react component.

API doc - https://github.com/video-dev/hls.js/blob/master/docs/API.md#startlevel

@staniwasd staniwasd requested a review from a team as a code owner September 16, 2023 14:28
@vercel
Copy link

vercel bot commented Sep 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
elements-demo-create-react-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2023 0:28am
elements-demo-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2023 0:28am
elements-demo-svelte-kit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2023 0:28am
elements-demo-vanilla ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2023 0:28am
elements-demo-vue ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2023 0:28am

@cjpillsbury
Copy link
Contributor

Hey @staniwasd,

Appreciate the eager and proactive engagement with the Open Elements project! Some way of programmatically stipulating a preferred initial rendition/media playlist sounds like a good feature add. For these kinds of changes, we'll want to discuss with the team before merging them, including details on how we'd want to solve that general problem.

Just in case we don't accept this PR, I'd recommend starting with filing a Feature Request Issue to avoid any wasted effort on your part. Also, when it comes to directly exposing hls.js API details (including config), we've been very intentional about the shape of this API, as we don't want to be overly-coupled to relying on this as our underlying "playback engine". Additionally, if we do end up exposing some API for starting rendition/level/playlist, we'll probably want that to be implemented for the other elements as well.

Let me check in with the team and get back to you on how we'd like to approach this! Assuming folks from the team are on board, if you're still interested in contributing, we can let you know what changes we'd want for a more general solution here.

Thanks again!

@cjpillsbury
Copy link
Contributor

Closing this. Intended purpose of the changes should be covered by #833

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants