feat: Bandwidth/Request Metrics #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c932b63.
| player = player, | ||
| collector = collector, | ||
| trackedResponseHeaders = listOf( | ||
| TrackedHeader.ExactlyIgnoreCase("x-cdn"), |
There was a problem hiding this comment.
AVPlayer unfortunately only lets one object listen to these at a time (without weird runtime hacks), ExoPlayer got this right
library-exo/src/main/java/com/mux/stats/sdk/muxstats/ExoPlayerBinding.kt
Show resolved
Hide resolved
library-exo/src/main/java/com/mux/stats/sdk/muxstats/bandwidth/BandwidthMetrics.kt
Show resolved
Hide resolved
library-exo/src/main/java/com/mux/stats/sdk/muxstats/bandwidth/BandwidthMetrics.kt
Show resolved
Hide resolved
andrewjl-mux
approved these changes
Jun 28, 2023
…ia3 into feat/bandwidth
|
I think there's some larger refactoring that can be done to promote test-ability, but I'm going to save it for after I finish ad metrics |
Merged
daytime-em
added a commit
that referenced
this pull request
Jul 5, 2023
## Improvements * feat: Add Rendition Changes, Quality, ExoPlayer-Specific Featues (#11) * feat: Add Session Data for internal experiments (#13) * feat: Bandwidth/Request Metrics (#12) * feat: IMA Ads with new API (#14) * feat: add error tracking (#16) * feat: Add Livestream Latency Metrics (#15) * Update to Core Android v0.7.5 Co-authored-by: Emily Dixon <edixon@mux.com> Co-authored-by: GitHub <noreply@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds request and detailed rendition/segment tracking
This doesn't include live latency, which I'm going to try to separate out into another class