Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add KDoc Update Flow #22

Merged
merged 4 commits into from
Aug 1, 2023
Merged

Add KDoc Update Flow #22

merged 4 commits into from
Aug 1, 2023

Conversation

daytime-em
Copy link
Collaborator

Because this SDK is unbundled, we have to do some extra work to configure theming and stuff. I think it might be worth returning to this task later.

Because this SDK is unbundled, we have to do some extra work to configure theming and stuff. I think it might be worth returning to this task later.
Copy link

@cjpillsbury cjpillsbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: Looks like you have some lingering copypasta `moduleName = "Mux Upload SDK". Otherwise, 👌

@daytime-em
Copy link
Collaborator Author

daytime-em commented Aug 1, 2023

@cjpillsbury Good catch, thank you! Updated :)

Copy link

@cjpillsbury cjpillsbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@daytime-em daytime-em merged commit e5cf4c0 into main Aug 1, 2023
2 checks passed
@daytime-em daytime-em deleted the ed/auto-docs branch August 1, 2023 18:46
@daytime-em daytime-em mentioned this pull request Aug 1, 2023
daytime-em added a commit that referenced this pull request Aug 1, 2023
## New
* Add KDoc at [devdocs.mux.com](devdocs.mux.com) (#22)

## Fixes

* Fix: Unhide ImaAdsSdkListener.create (#23)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants