keep json encoding inside load and save asset functions

muxinc · Aug 1, 2024 · acd8322 · acd8322
1 parent 85e2f19
commit acd8322
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/src/assets.ts b/src/assets.ts
@@ -48,8 +48,7 @@ export interface AssetSource {
 export async function getAsset(filePath: string): Promise<Asset | undefined> {
   const { loadAsset } = await getVideoConfig();
   const assetConfigPath = await getAssetConfigPath(filePath);
-  const jsonAsset = await loadAsset(assetConfigPath);
-  const asset = JSON.parse(jsonAsset);
+  const asset = await loadAsset(assetConfigPath);
   return asset;
 }
 
@@ -107,7 +106,7 @@ export async function createAsset(
     }
   }
 
-  videoConfig.saveAsset(assetConfigPath, JSON.stringify(newAssetDetails));
+  videoConfig.saveAsset(assetConfigPath, newAssetDetails);
 
   return newAssetDetails;
 }
@@ -130,7 +129,7 @@ export async function updateAsset(
 
   newAssetDetails = transformAsset(transformers, newAssetDetails);
 
-  await saveAsset(assetConfigPath, JSON.stringify(newAssetDetails));
+  await saveAsset(assetConfigPath, newAssetDetails);
 
   return newAssetDetails;
 }

diff --git a/src/config.ts b/src/config.ts
@@ -5,6 +5,7 @@ import { stat, readFile, writeFile, mkdir } from 'node:fs/promises';
 import { pathToFileURL } from 'node:url';
 import nextConfig from 'next/config.js';
 import type { NextConfig } from 'next';
+import { Asset } from './assets';
 // @ts-ignore
 const getConfig = nextConfig.default;
 
@@ -27,8 +28,8 @@ export type VideoConfigComplete = {
   /* An optional function to generate the local asset path for remote sources. */
   remoteSourceAssetPath?: (url: string) => string;
 
-  loadAsset: (path: string) => Promise<string>;
-  saveAsset: (path: string, jsonAsset: string) => Promise<void>;
+  loadAsset: (path: string) => Promise<Asset>;
+  saveAsset: (path: string, asset: Asset) => Promise<void>;
 };
 
 export type ProviderConfig = {
@@ -72,10 +73,10 @@ export const videoConfigDefault: VideoConfigComplete = {
     const asset = JSON.parse(file.toString());
     return asset;
   },
-  saveAsset: async (assetPath, jsonAsset) => {
+  saveAsset: async (assetPath, asset) => {
     try {
       await mkdir(path.dirname(assetPath), { recursive: true });
-      await writeFile(assetPath, jsonAsset, {
+      await writeFile(assetPath, JSON.stringify(asset), {
         flag: 'wx',
       });
     } catch (err: any) {