Add some routes to list themes/players in JSON format #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
luwes
reviewed
Jul 8, 2024
| @@ -34,6 +34,7 @@ | |||
| "@player.style/microvideo": "0.0.5", | |||
| "@player.style/minimal": "0.0.5", | |||
| "@player.style/yt": "0.0.5", | |||
| "hls.js": "^1.5.13", | |||
There was a problem hiding this comment.
(blocking) this shouldn't be needed, did you run npm install in the root of this monorepo?
There was a problem hiding this comment.
Pretty sure? I don't think I ever did anything outside of the root of the monorepo, but I'll try a clean install this afternoon and see if I can reproduce.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was hacking around on some stuff over the holiday and found myself wanting to be able to programmatically retrieve available themes. This just exposes the
themesandplayerscontent collections as a route directly.Also added hls.js as a dependency because otherwise the entire project was blowing up.