Merge

.github/workflows/maven.yml

@@ -13,24 +13,30 @@ jobs:
 
   build:
     runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        java-version: [ 8, 11, 15 ]
     steps:
     - uses: actions/checkout@v2
-    - name: Set up JDK 1.8
+    - name: Set up JDK
       uses: actions/setup-java@v1
       with:
-        java-version: 1.8
+        java-version: ${{ matrix.java-version }}
     - name: Compile with Maven
       run: mvn -T 1C clean generate-sources compile --file pom.xml
 
   test:
     runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        java-version: [ 8, 11, 15 ]
     needs: [build]
     steps:
     - uses: actions/checkout@v2
-    - name: Set up JDK 1.8
+    - name: Set up JDK
       uses: actions/setup-java@v1
       with:
-        java-version: 1.8
+        java-version: ${{ matrix.java-version }}
     - name: Test with Maven
       run: mvn -T 1C test-compile test --file pom.xml
 
@@ -39,10 +45,10 @@ jobs:
     needs: [build, test]
     steps:
     - uses: actions/checkout@v2
-    - name: Set up JDK 1.8
+    - name: Set up JDK 11
       uses: actions/setup-java@v1
       with:
-        java-version: 1.8
+        java-version: 11
     - name: SonarCloud Scan
       run: mvn clean test jacoco:report org.jacoco:jacoco-maven-plugin:prepare-agent sonar:sonar -Dsonar.projectKey=java-fluent-validator -Dsonar.organization=mvallim -Dsonar.host.url=https://sonarcloud.io -Dsonar.login=$SONAR_TOKEN
       env:

README.md

@@ -10,6 +10,8 @@
 
 Validating data is a common task that occurs throughout any application, especially the business logic layer. As for some quite complex scenarios, often the same or similar validations are scattered everywhere, thus it is hard to reuse code and break the [DRY](https://en.wikipedia.org/wiki/Don%27t_repeat_yourself) rule.
 
+_**Compatible JDK 8, 11 and 15**_
+
 This library supports **`Kotlin`** aswell
 
 ## Sample

documentation/1-quick-start.md

@@ -12,7 +12,7 @@ You can pull it from the central Maven repositories:
 <dependency>
     <groupId>com.github.mvallim</groupId>
     <artifactId>java-fluent-validator</artifactId>
-    <version>1.9.2</version>
+    <version>1.9.3</version>
 </dependency>
 ```
 

pom.xml

@@ -1,11 +1,12 @@
 <project xmlns="http://maven.apache.org/POM/4.0.0"
 	xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
 	xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+
 	<modelVersion>4.0.0</modelVersion>
 
 	<groupId>com.github.mvallim</groupId>
 	<artifactId>java-fluent-validator</artifactId>
-	<version>1.9.3-SNAPSHOT</version>
+	<version>1.9.4-SNAPSHOT</version>
 	<packaging>jar</packaging>
 
 	<properties>
@@ -72,9 +73,9 @@
 			</plugin>
 
 			<plugin>
-				<groupId>org.codehaus.mojo</groupId>
+				<groupId>com.nickwongdev</groupId>
 				<artifactId>aspectj-maven-plugin</artifactId>
-				<version>1.11</version>
+				<version>1.12.6</version>
 				<configuration>
 					<Xlint>adviceDidNotMatch=ignore</Xlint>
 					<complianceLevel>${java.version}</complianceLevel>
@@ -107,7 +108,7 @@
 			<plugin>
 				<groupId>org.jacoco</groupId>
 				<artifactId>jacoco-maven-plugin</artifactId>
-				<version>0.8.5</version>
+				<version>0.8.6</version>
 				<configuration>
 					<excludes>
 						<exclude>**/test/**</exclude>
@@ -366,4 +367,4 @@
 			</build>
 		</profile>
 	</profiles>
-</project>
+</project>

src/main/java/br/com/fluentvalidator/AbstractValidator.java

@@ -4,6 +4,7 @@
 import java.util.Collections;
 import java.util.LinkedList;
 import java.util.List;
+import java.util.concurrent.atomic.AtomicReference;
 import java.util.function.Function;
 import java.util.stream.Collectors;
 
@@ -22,26 +23,49 @@ public abstract class AbstractValidator<T> implements Validator<T> {
 
   private final List<Rule<T>> rules = new LinkedList<>();
 
-  private final Runnable initialize;
+  private final Initializer<T> initialize;
 
   private String property;
 
   private RuleProcessorStrategy ruleProcessor = RuleProcessorStrategy.getDefault();
 
-  protected AbstractValidator() {
-    this.initialize = new Runnable() {
-
-      private boolean initialized;
-
-      @Override
-      public synchronized void run() {
-        if (!initialized) {
-          rules();
-          this.initialized = true;
+  private static class Initializer<T> {
+
+    private final AtomicReference<Boolean> atomicReference = new AtomicReference<>(Boolean.FALSE);
+
+    private final Validator<T> validator;
+
+    Initializer(final Validator<T> validator) {
+      this.validator = validator;
+    }
+
+    /**
+     * This method cause Race Condition. We are using Compare And Swap (CAS)
+     * <p>
+     * {@link https://en.wikipedia.org/wiki/Race_condition}
+     * {@link https://en.wikipedia.org/wiki/Compare-and-swap}
+     */
+    public void init() {
+      if (isNotInitialized()) {
+        synchronized (atomicReference) {
+          if (isNotInitialized()) { // double check if was initialized
+            validator.rules();
+            final Boolean oldValue = atomicReference.get();
+            final Boolean newValue = Boolean.TRUE;
+            atomicReference.compareAndSet(oldValue, newValue);
+          }
         }
       }
+    }
+
+    private boolean isNotInitialized() {
+      return Boolean.FALSE.equals(atomicReference.get());
+    }
 
-    };
+  }
+
+  protected AbstractValidator() {
+    this.initialize = new Initializer<>(this);
   }
 
   /**
@@ -114,7 +138,7 @@ public <E> List<E> validate(final Collection<T> instances, final ValidationResul
    */
   @Override
   public boolean apply(final T instance) {
-    this.initialize.run();
+    this.initialize.init();
     ValidationContext.get().setProperty(this.property, instance);
     return ruleProcessor.process(instance, instance, rules);
   }