Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile updates #189

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Conversation

rca
Copy link

@rca rca commented Jun 12, 2017

Hello,

This pull request changes Dockerfile so that the local working copy of localshop is built into a Docker image. This is completely different from the way it currently works; feedback welcome.

Thank you.

@codecov
Copy link

codecov bot commented Jun 12, 2017

Codecov Report

Merging #189 into develop will increase coverage by 3.12%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #189      +/-   ##
===========================================
+ Coverage    82.15%   85.28%   +3.12%     
===========================================
  Files           36       33       -3     
  Lines         1390     1155     -235     
===========================================
- Hits          1142      985     -157     
+ Misses         248      170      -78
Impacted Files Coverage Δ
localshop/apps/dashboard/views.py 57.14% <0%> (-4.1%) ⬇️
localshop/apps/dashboard/urls.py 100% <0%> (ø) ⬆️
localshop/__init__.py
localshop/utils.py
localshop/views.py
localshop/urls.py
localshop/apps/permissions/migrations/__init__.py 100% <0%> (ø)
localshop/apps/permissions/utils.py 92.5% <0%> (+9.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c46af28...41168e3. Read the comment docs.

@rca
Copy link
Author

rca commented Jul 19, 2017

Checking in on this, ping @mvantellingen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant