Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup and small performance improvements #8

Merged
merged 12 commits into from
Nov 12, 2020
Merged

Cleanup and small performance improvements #8

merged 12 commits into from
Nov 12, 2020
+120 −89

Conversation

stokito
Copy link

@stokito stokito commented Jul 23, 2020

Embedded Android devices are slow so it makes sense to do some basic optimizations.
Almost all these optimization was just made automatically by Android Studio so the refactoring should is safe.

stokito added 12 commits July 23, 2020 13:55
@stokito
build.gradle fix typo
e1ceaee
@stokito
ServerHandler: replace substring(0, n).equals() calls with startsWith()
31cb26d 
Ignored exceptions should be named as "ignored" to make linter happy
@stokito
Use primitive int and remove unused initializers
df760f9
@stokito
Rename constructor params.
4908183 
Make the msgHandler not static.
Make field final.
Make PartialRange and FileInfo classes final (improves performance)
@stokito
PartialRange: migrate to primitive long
efb7d61
@stokito
Rename methods: abbreviations follows camel case
195407e
@stokito
Move MIME to Constants
9174074
@stokito
MIME: remove non needed cloning to new ArrayList
97602c8
@stokito
MIME: extract MimeType class
60209d2 
getMimeTypeForDocument(): containsKey() internally makes the same get()
@stokito
directoryHtmlIndex(): init array list woth capacity
f846910
@stokito
extract precompiled regexp patterns
160af16
@stokito
Add first unit test
1e75cbb
@stokito
Copy link
Author

stokito commented Aug 16, 2020

Hi @mvbasov please take a look on the PR. I would like to send another PR but I want to know if the project is alive

@mvbasov mvbasov merged commit 4b26fde into mvbasov:master Nov 12, 2020
@mvbasov
Copy link
Owner

mvbasov commented Nov 12, 2020

Thank You for your work!
Project is alive but I spent only free time for it.
1/2 year reaction time is normal for this project ;)

@mvbasov
Copy link
Owner

mvbasov commented Nov 12, 2020

You warm up my interest to this project:)
The main problem of this project now is reaction to switch network.
The main idea is:

  • I don't allow to application work on cellular network (for security reason). It is done
  • Server need to disconnect if network changed. It is done
  • Server need to bind to all kind of local network interfaces:
    • WiFi (done)
    • Ethernet (for using on TV boxes)(not done)
    • On all kind of tethering interfaces (done only for WiFi tethering)
    • As fallback bind to loopback (done)

@stokito
Copy link
Author

stokito commented Nov 12, 2020

Thank you. Basically I’m interested in your server because it’s the only one available on my xiomi Android TV installed via F-droid. I saw few other http and even webdav servers in App Store but looks like only your supports TV boxes.
To be honest you can just include Jetty webserver or maybe even tomcat embedded. They are much bigger but already supported, audited and well known.

@stokito stokito deleted the cleanup branch November 12, 2020 03:41
@mvbasov
Copy link
Owner

mvbasov commented Nov 12, 2020 •
edited
Loading

You will be laugh. It not operate on my TV box :)
I need more free time to implement handling ethernet connection:(
Jetty web server is a good solution but "killer feature" of this project is to be lightweight. See name of this project.
The idea was write simplest web server for Android. It can be good base for another projects as I think.
The F-Droid release will be little bit later. I need to test new code. Also F-Droid ecosystem has very complex release workflow...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stokito @mvbasov