Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove newlines immediately after assignment operators #157

Merged
merged 1 commit into from
Oct 13, 2021

Conversation

kaperys
Copy link
Contributor

@kaperys kaperys commented Oct 12, 2021

Addresses #76

format/format.go Outdated Show resolved Hide resolved
format/format.go Outdated Show resolved Hide resolved
@kaperys kaperys requested a review from mvdan October 13, 2021 09:54
Copy link
Owner

@mvdan mvdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff. Will squash-merge, assuming that's OK.

@mvdan
Copy link
Owner

mvdan commented Oct 13, 2021

Oh, I forgot to mention - we should document this rule in the README. Do you want to add it?

The README table is getting very large, so it's due for a rethink, but we should keep it complete anyway.

@kaperys
Copy link
Contributor Author

kaperys commented Oct 13, 2021

Ofcourse. Apologies, I should have thought of that. I've updated the README.

README.md Outdated Show resolved Hide resolved
@kaperys kaperys force-pushed the remove-assignment-newlines branch from 3d57b16 to b5591b7 Compare October 13, 2021 13:35
@mvdan
Copy link
Owner

mvdan commented Oct 13, 2021

:cheffs-kiss:

@mvdan mvdan merged commit f3595ed into mvdan:master Oct 13, 2021
@kaperys kaperys deleted the remove-assignment-newlines branch October 13, 2021 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants