Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/shfmt: remove inline EditorConfig comments #1017

Merged
merged 1 commit into from
Jul 13, 2023
Merged

cmd/shfmt: remove inline EditorConfig comments #1017

merged 1 commit into from
Jul 13, 2023

Conversation

slabstone
Copy link
Contributor

EditorConfig 0.15.0 does not allow inline comments

https://spec.editorconfig.org/#no-inline-comments

@slabstone
cmd/shfmt: remove inline EditorConfig comments
377fda7 
EditorConfig 0.15.0 does not allow inline comments
mvdan
mvdan approved these changes Jul 12, 2023
View reviewed changes
Copy link
Owner

@mvdan mvdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. I can understand why they made that change, but I admit it's a shame to not be able to use inline comments.

@mvdan mvdan merged commit 1cb4b28 into mvdan:master Jul 13, 2023
8 checks passed
@slabstone slabstone deleted the editorconfig branch July 17, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvdan mvdan mvdan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slabstone @mvdan