cmd/shfmt: add --apply-ignore flag for tools and editors #1051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The EditorConfig ignore=true property is currently only obeyed
when walking directories, which is fine for command line users
running shfmt like
shfmt -l -w .
However, many tools and editor integrations use shfmt via stdin
or by passing a single file argument, and in those cases,
the ignore=true logic does not kick in at all.
There should be a way for a user to force running shfmt on a file,
and that has always been passing a file as a direct argument, like:
shfmt -w file.sh
We can't break that, but tools do need a way to obey ignore rules.
For that reason, add an --apply-ignore flag which does just that.
Fixes #1037.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(see commit message)
Fixes #1037.