Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interp: add initial mapfile or readarray builtin #863

Merged
merged 1 commit into from
May 19, 2022

Conversation

lollipopman
Copy link
Contributor

@lollipopman lollipopman commented May 18, 2022

Add an initial implementation of mapfile or readarray, this version only
supports the basic options of -d, -t, and a custom array variable
name. At present it only support splitting on ASCII delimiters.

@lollipopman lollipopman force-pushed the mapfile branch 2 times, most recently from 709df18 to 0fa8249 Compare May 18, 2022 16:28
Copy link
Owner

@mvdan mvdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just some nits.

I take it that these are fairly Bash-specific, which is fine.

interp/builtin.go Outdated Show resolved Hide resolved
interp/builtin.go Outdated Show resolved Hide resolved
interp/builtin.go Outdated Show resolved Hide resolved
Add an initial implementation of mapfile or readarray, this version only
supports the basic options of `-d`, `-t`, and a custom array variable
name. At present it only support splitting on ASCII delimiters.
@lollipopman
Copy link
Contributor Author

Thanks for the careful review @mvdan, I believe this is now ready to merge.

@mvdan mvdan merged commit 70e9588 into mvdan:master May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants