Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more intuitive portable-atomic feature etc. #172

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

brody4hire
Copy link

@brody4hire brody4hire commented Feb 4, 2025

Fixes #170 - non-breaking feature update - based on & supersedes PR #171

UPDATED as follows

  • include dep: syntax updates from PR Use dep: syntax for portable-atomic #171
  • update some documentation to update reference & avoid duplicated info
  • increase MSRV to 1.60 in Cargo.toml & in .github/
  • crate version -> 0.10.0

I have also tried CI in my own fork: brody4hire#1


P.S. I was hoping that the implicit feature support would be removed in Rust 2024, which is part of the root cause, but this update is now held up: rust-lang/cargo#12826 (comment)


/cc @jamesmunns @Dirbaio

@zesterer
Copy link
Collaborator

zesterer commented Feb 9, 2025

Any chance you could bump the MSRV too? You can find it in .github/

@brody4hire brody4hire force-pushed the less-confusing-portable-atomic-option branch from fe7f192 to a255f07 Compare February 16, 2025 21:33
@brody4hire brody4hire changed the title less confusing portable-atomic option more intuitive portable-atomic option etc. Feb 16, 2025
@brody4hire brody4hire marked this pull request as draft February 16, 2025 21:49
@brody4hire brody4hire force-pushed the less-confusing-portable-atomic-option branch from a255f07 to bc95aa5 Compare February 16, 2025 22:12
@brody4hire brody4hire changed the title more intuitive portable-atomic option etc. more intuitive portable-atomic feature etc. Feb 16, 2025
@brody4hire brody4hire marked this pull request as ready for review February 16, 2025 22:17
@brody4hire
Copy link
Author

I have now rebased this PR on PR #171, updated some documentation to avoid duplicated info, updated MSRV in both Cargo.toml & .github/, etc. I have also updated the crate version in its own commit in case this may be helpful.

Please let me know if anything else is needed from me, my apologies for the delay.

/cc @jamesmunns @Dirbaio

@brody4hire brody4hire marked this pull request as draft February 17, 2025 17:10
Authored-by: James Munns <james@onevariable.com>
Co-authored-by: @brody4hire - C. Jonathan Brody <brody4hire@brodycj.com>
Authored-by: James Munns <james@onevariable.com>
@brody4hire brody4hire force-pushed the less-confusing-portable-atomic-option branch from bc95aa5 to aed6a8e Compare February 24, 2025 00:09
@brody4hire brody4hire marked this pull request as ready for review February 24, 2025 00:11
@brody4hire
Copy link
Author

Now updated again, as discussed, tested in my personal fork: brody4hire#1

Please let me know if anything else is needed from me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature naming is likely to cause confusion
2 participants