Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to load either rexml or nokogiri #132

Merged
merged 1 commit into from
May 4, 2023

Conversation

SchorppDA
Copy link
Contributor

Make it possible to load either rexml or nokogiri.
Since nokogiri is preferably selected in the code, it should also be possible to work without rexml at all.
This is necessary for Ruby installations that don't have the bundled gems, e.g. when used on embedded devices.

@coveralls
Copy link

Coverage Status

Coverage: 95.279% (-0.05%) from 95.324% when pulling 3e0443e on SchorppDA:master into 5ebbafd on mvidner:master.

@mvidner
Copy link
Owner

mvidner commented May 4, 2023

Thanks!

Ideally I would like to say in gemspec that we depend on either rexml or nokogiri but I think the gem system cannot express that (unlike RPM where you can Provide a xml_library symbol to be Required downstream)

I just need to add a NEWS item and comment the requirements in the gemfile.

(Another level would be making a XML parser completely optional, by showing the users how to declare proxies without calling Introspect, and using that in Connection#request_name)

@mvidner mvidner merged commit 3e0443e into mvidner:master May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants