Interface not found: DBus::Error instead of nil (and then NoMethodError) #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aschnell this is a fix for one of the things you reported |
|
LGTM except for the testsuite issues. |
The example below would be correct if it said
`unit_o["org.freedesktop.systemd1.Unit"]`.
With the wrong interface name, `unit_i` used to become `nil` and you
would get an unhelpful
"NoMethodError: undefined method `[]' for nil:NilClass" later.
With this fix, it raises
"DBus::Error: no such interface `Unit' on object `/org/freedesktop/systemd1/unit/_2d_2emount'"
```rb
bus = DBus::SystemBus.instance
svc = bus.service("org.freedesktop.systemd1")
unit_o = svc["/org/freedesktop/systemd1/unit/_2d_2emount"]
unit_i = unit_o["Unit"] # BUG
descr = unit_i["Description"]
```
mvidner
force-pushed
the
unknown-interface
branch
from
578f9fa
to
794f3cc
Compare
1 similar comment
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Jan 25, 2021
https://build.opensuse.org/request/show/865300 by user coolo + dimstar_suse - 0.16.0 API: * An invalid service name or an invalid object path will raise instead of being sent to the bus. The bus would then drop the connection, producing EOFError here (gh#mvidner/ruby-dbus#80). - 0.15.0 API: * Accessing an unknown interface will raise instead of returning nil (gh#mvidner/ruby-dbus#74). Bug fixes: * Fixed a conflict with activesupport 5.2 (gh#mvidner/ruby-dbus#71)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.