Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x11docker-gui /usr/bin/catatonit: invalid option -- 's' #189

Closed
philuser opened this issue Oct 21, 2019 · 2 comments
Closed

x11docker-gui /usr/bin/catatonit: invalid option -- 's' #189

philuser opened this issue Oct 21, 2019 · 2 comments
Labels

Comments

@philuser
Copy link

Hello,
when I run x11docker-gui, I systematically get the error:

$ x11docker-gui
...
/usr/bin/catatonit: invalid option -- 's'
usage: catatonit [-ghLV] [--] <progname> [<arguments>...]

My file x11docker.log
catatonit according to what I saw is a particularity of opensuse https://github.com/openSUSE/catatonit.
In the x11docker.log.

378  |69	Tini='/usr/bin/catatonit'
392  |83	storeinfo test tini && Tini="$(storeinfo dump tini) -s --" || Tini=''

but the catatonit process does not have the -s switch

How can I fix this?

Thank you.

mviereck added a commit that referenced this issue Oct 21, 2019
Do not set `tini` option `-s`. Avoids issue with `catatonit`. #189
@mviereck mviereck added the bug label Oct 21, 2019
@mviereck
Copy link
Owner

Thank you for the report and already pointing on the relevant code parts!
I wasn't aware of catatonit on openSUSE, good to know.

I've fixed the bug, x11docker does not use the switch -s anymore. Instead it sets environment variabe TINI_SUBREAPER=1.
catatonit will run as a subreaper automatically and does not need a switch.

Please update x11docker. Aternatively you could just set Tini='' in the code, it is not really important at this point, it just serves to have a clean process tree.

@philuser
Copy link
Author

Great. Great.

What a surprising reactivity, bravo.

I'll test it at the end of the day, I'll make a comeback.

And thanks again for the work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants