-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Brave browser #43
Comments
I did a test build with:
I can run it successfully with brave seems to be a fork of chromium. Maybe you miss just the |
Ok, I used your docker.. This seems error stands out:: [8:74:0507/211349.648008:ERROR:bus.cc(394)] Failed to connect to the bus: Failed to connect to socket /var/run/dbus/system_bus_socket: No such file or directory |
I have this similar error messages, but with a successfull startup. So far I consider them rather harmless. The dbus error occurs due to missing dbus in container, but brave can run without it:
The signifcant error messages from your log are from this type:
Though, I am not sure what this error means. Possibilities to try out:
|
The host OS is Ubuntu 18.04 LTS .. Release: 18.04 A low
The virtual memory limit on the host and during the docker build is "unlimited".. Maybe docker needs an extra paramter to incrase its memory limit. There are several docker run parameters that might do this.. --shm-size nG for example .. Is there a good way to test these out? |
You can add docker run options in
Did you test the following?
Comparing with a chromium image could give some hints, too:
|
Sorry, forgot to mention .. I did try all those options and with the new libraries.. In every case the same error shows up.. I see the memory flag got passed to docker run but that did not help. This might be related: docker/compose#1339 I don't see any updates for docker.io in the bonic repo yet.. |
It seems that this bug happens on host, not in container.
Is bonic the tag name for ubuntu 18.04? What does
Did you try the chromium example? I give some hints for troubleshooting here: https://github.com/mviereck/x11docker#troubleshooting
If it runs, reduce the options from last to first until only one is left. I did a test build with debian 9 as base image, runs with same messages here:
|
Maybe I found the issue: I noticed your docker command in logfile still has option The bug report you linked to mentioned something about Run |
The update works .. thank you .. For the record
|
## Added - Forward `stdin` of x11docker to container command with a named pipe/fifo. ## Changed - `x11docker-gui`: Use stdin for kaptain grammar transmission. Don't use cache. - `--dbus-system`: Don't create `--tmpf /tmp --tmpfs /run --tmpfs /var/run --tmpfs /run/lock`. [(#43)](#43) - Some internal improvements for faster startup and shutdown. ### Fixed - `x11docker-gui`: fixed x11docker startup failure due to changed stdout output.
Great! I've just published 4.2.1 release. It allows you to run brave with dbus system daemon in container. You will get less error messages:
|
Hi mviereck, This is the first time I've done anything with docker and I interestingly chose brave browser as my first project! I learned a lot from this issue with jcalfee, but wanted to know if you knew why --no-sandbox is needed to actually get brave to work? I get a message in brave just below the URL line that says.... "You are using an unsupported command-line flag: --no-sandbox. Stability and security will suffer." EDIT: 4/23/2021 @ 1:07am - So I tried renaming the container while it was running. It worked and when I stopped it wasn't deleted, but I'm not sure how to get it started again. Any help would be great! Clayton |
brave is based on chromium. chromium has some sort of sandboxing for each tab (I don't know the details). This sort of sandboxing needs advanced privileges that are disabled in docker containers by default.
x11docker always drops used conbtainers and starts fresh ones from the image.
Thank you :-) |
--home worked great for one instance. As soon as I started another, the brave profile was locked, so I won't be able to have multiple instances with separate profiles unless I build multiple images, but that's shouldn't be a big deal. Thanks again! Clayton |
You can specify a different storage dir with |
Any ideas on how to proceed with the brave browser?
The text was updated successfully, but these errors were encountered: