Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Status codes implementation, addresses #371 #372

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Status codes implementation, addresses #371 #372

wants to merge 2 commits into from

Conversation

hryamzik
Copy link

No description provided.

@hryamzik
Copy link
Author

I've just spotted this metrics disappears after some time, not sure why this happens yet.

@hryamzik
Copy link
Author

hryamzik commented Dec 1, 2021

For some reason zero value for status gauge leaded to metric absence, fixed this by avoiding this value.

@mvisonneau
Copy link
Owner

Thanks for this contribution @hryamzik, overall that seems fine with me. I would feel more at ease to put it behind a flag in a non-default fashion to avoid potential breaking changes though. Would you be happy to introduce it as part of this change?

@hryamzik
Copy link
Author

Can you thing of any scenarios where this behavior update would break things down? I can't imagine any for grafana but not that sure about alert manager rules. So far hiding this behind a flag looks like an extra complexity to me.

@mvisonneau mvisonneau force-pushed the main branch 3 times, most recently from f1d1bc5 to 718e730 Compare May 23, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hryamzik @mvisonneau