Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(devenv): Fix devenv rule in makefile. #822

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

audig
Copy link
Contributor

@audig audig commented Apr 9, 2024

Fix some issue when running make dev-env.

  • Remove call to unexisting rule setup.
  • Set the Golang version in a variables, with the actual version.
  • Set a safe directory to avoid error obtaining VCS status: exit status 128

Remove call to unexisting rule `setup`. Set the Golang version in a variables, with the actual version. Set a safe directory to avoid `error obtaining VCS status: exit status 128`
@audig audig force-pushed the fix/make-dev-env branch from d6ab7af to 2a1feab Compare April 9, 2024 18:35
Copy link
Owner

@mvisonneau mvisonneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a ton @audig!

@mvisonneau mvisonneau merged commit 738c141 into mvisonneau:main Apr 9, 2024
4 checks passed
@coveralls
Copy link

Coverage Status

coverage: 65.356%. remained the same
when pulling 2a1feab on audig:fix/make-dev-env
into 87f505e on mvisonneau:main.

phozzy pushed a commit to phozzy/gitlab-ci-pipelines-exporter that referenced this pull request Apr 16, 2024
Remove call to unexisting rule `setup`. Set the Golang version in a variables, with the actual version. Set a safe directory to avoid `error obtaining VCS status: exit status 128`
phozzy added a commit to phozzy/gitlab-ci-pipelines-exporter that referenced this pull request Apr 17, 2024
fix(devenv): Fix devenv rule in makefile. (mvisonneau#822)

Remove call to unexisting rule `setup`. Set the Golang version in a variables, with the actual version. Set a safe directory to avoid `error obtaining VCS status: exit status 128`

go.mod: updated most dependencies

make: updated urfave version to build completion helpers

Optimise memory consumption
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants