Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for matplotlib rc_context issue #2925

Merged
merged 2 commits into from
Jul 31, 2022
Merged

Conversation

mwaskom
Copy link
Owner

@mwaskom mwaskom commented Jul 30, 2022

It's not necessary to use rc_context because we know exactly what parameter we want to change (although it does require implementing a custom context manager).

The only effect of this rcparam is to toggle the layout parameter of plt.figure() (actually mpl.figure.Figure), so really we could just pass a parameter there. But matplotlib is in the middle of a dance with the tight_layout/layout parameters, so handling the various forwards/backwards compatibility issues seems too complicated for now.

Fixes #2914
More context at matplotlib/matplotlib#23298

@codecov
Copy link

codecov bot commented Jul 30, 2022

Codecov Report

Merging #2925 (3132feb) into master (f581300) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2925   +/-   ##
=======================================
  Coverage   98.24%   98.24%           
=======================================
  Files          69       69           
  Lines       22866    22874    +8     
=======================================
+ Hits        22464    22472    +8     
  Misses        402      402           
Impacted Files Coverage Δ
seaborn/axisgrid.py 97.17% <100.00%> (ø)
seaborn/utils.py 95.08% <100.00%> (+0.11%) ⬆️

@mwaskom mwaskom merged commit 6460a21 into master Jul 31, 2022
@mwaskom mwaskom deleted the workaround/rc_context branch July 31, 2022 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

displot instantly close upon display when using seaborn 0.11.2 with matplotlib 3.5.2
1 participant