Address inf_as_na pandas deprecation #3424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwaskom
reviewed
Jul 22, 2023
seaborn/_base.py
Outdated
| # it is similar to GH2419, but more complicated because | ||
| # supporting `order` in categorical plots is tricky | ||
| orig = orig[orig.isin(self.var_levels[var])] | ||
| orig = orig.replace(np.inf, np.nan).dropna() |
There was a problem hiding this comment.
Good call. Added -np.inf
|
@mroeschke any idea why this is still failing? FWIW seaborn tests are now failing on the pandas rc as a result of the change so it would be good to sort this out. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #3424 +/- ##
=======================================
Coverage 98.32% 98.32%
=======================================
Files 77 77
Lines 24303 24305 +2
=======================================
+ Hits 23897 23899 +2
Misses 406 406
|
|
Okay got this to pass. I think the tested version of pandas (1.2) has a bug where |
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will be deprecated in pandas 2.1 https://pandas.pydata.org/docs/dev/whatsnew/v2.1.0.html#deprecations