Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Squash a large number of warnings in the tests #3447

Merged
merged 15 commits into from
Aug 25, 2023
Merged

Squash a large number of warnings in the tests #3447

merged 15 commits into from
Aug 25, 2023

Conversation

mwaskom
Copy link
Owner

@mwaskom mwaskom commented Aug 25, 2023

Various small edits to:

  • Maintain forward compatibility with upcoming changes in dependencies
  • Avoid triggering some numpy warnings around missing data and discrete mapping logic
  • Silence a couple of innocuous warnings there's no clear way to work around

All that remains here are matplotlib/matplotlib#26300, matplotlib/matplotlib#26596 and pytest-dev/pytest-xdist#840 (decided to ignore the latter in the test config, since there's no apparent movement towards dealing with it upstream despite lots of reports).

@mwaskom mwaskom added this to the v0.13.0 milestone Aug 25, 2023
@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #3447 (a03a90c) into master (b3e6b8d) will decrease coverage by 0.01%.
The diff coverage is 95.65%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3447      +/-   ##
==========================================
- Coverage   98.32%   98.32%   -0.01%     
==========================================
  Files          77       77              
  Lines       24413    24415       +2     
==========================================
+ Hits        24004    24005       +1     
- Misses        409      410       +1     
Files Changed Coverage Δ
tests/test_distributions.py 99.67% <87.50%> (-0.07%) ⬇️
seaborn/_base.py 97.55% <100.00%> (-0.02%) ⬇️
seaborn/_core/plot.py 98.26% <100.00%> (ø)
seaborn/_core/properties.py 99.05% <100.00%> (ø)
seaborn/_stats/counting.py 100.00% <100.00%> (ø)
seaborn/categorical.py 98.90% <100.00%> (+<0.01%) ⬆️
seaborn/distributions.py 96.23% <100.00%> (-0.01%) ⬇️
tests/_stats/test_density.py 100.00% <100.00%> (ø)
tests/conftest.py 100.00% <100.00%> (ø)
tests/test_categorical.py 99.13% <100.00%> (ø)

@mwaskom
Copy link
Owner Author

mwaskom commented Aug 25, 2023

Merging over codecov as it's just flagging a line that is version gated to a forthcoming matplotlib release.

@mwaskom mwaskom merged commit 9049ddd into master Aug 25, 2023
11 of 12 checks passed
@mwaskom mwaskom deleted the maint/warnings branch August 25, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant