Treat binwidth as approximate to avoid dropping outermost datapoints #3489
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the interpretation of the
binwidth
parameter inhistplot
andobjects.Hist
.With the previous implementation, floating point errors could cause the largest datapoint(s) to be silently dropped. The solution here is to always honor the bin range (either the explicit as specified through
binrange
or implicit as computed from the data range) and to make the actual bin width only approximately equal to thebinwidth
parameter whenbinwidth
does not evenly divide it.I could not think of a simple + robust solution to detect and handle floating point issues while also reliably honoring expected bin ranges, and I think that the expected violation of expectations will be smaller this way, although it is a minor API change. In most cases it should not be noticeable.
Fixes #3220