Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wavelet exceptions and expand cwt operator docstr #6

Merged
merged 2 commits into from
Jul 6, 2023
Merged

Conversation

kubo11
Copy link
Collaborator

@kubo11 kubo11 commented Jul 3, 2023

Wavelet constructor exceptions are now being handled correctly. Morlet wavelet C argument has been removed.
The CWT operator docstr has been updated.

Category:

Description:

Additional information:

Affected modules and functionalities:

Key points relevant for the review:

Tests:

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

@kubo11 kubo11 requested a review from mwdowski July 3, 2023 00:59
Wavelet constructor exceptions are now being handled correctly.
Morlet wavelet C argument has been removed.
as list of float32 values.
- HAAR - none
- GAUS - n (order of derivative)
- MEXH - sigma ()
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sigma

@kubo11 kubo11 merged commit 3c36192 into main Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants