Addressed Clement's notes on generation_methods.py and fixed docstrings in generator.py #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed collision bug
Renaming of the generator left for group discussion.
mwolinska
force-pushed
the
pull-request-final
branch
2 times, most recently
from
90a3e86
to
8032c57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed the docstrings in generator.py (notes 2-3)
I implemented all Clement's suggested changes to generation_methods.py (notes 6-16)
The following were left alone pending group decisions:
I did not rename the ParallelRandomWalkGenerator (note 1) in generator.py
I did not change the type from "AgentT" to "Agent" (notes 4-5) in types.py
I did not move move everything from ParallelRandomWalk inside ParallelRandomWalkGenerator (note 16) in generator.py