Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger an horizontal scroll through on overflow #282

Merged
merged 5 commits into from
Jun 19, 2024
Merged

Trigger an horizontal scroll through on overflow #282

merged 5 commits into from
Jun 19, 2024

Conversation

mwouts
Copy link
Owner

@mwouts mwouts commented Jun 2, 2024

This change improves the rendering of wide tables.

The horizontal scroll bar appears on the table itself, meaning that the search and pagination control remain visible as we scroll.

Thanks to this change, we get a more uniform rendering among Jupyter, Jupyter Book, VS Code and Streamlit.

Copy link

github-actions bot commented Jun 2, 2024

Thank you for making this pull request.

Did you know? You can try it on Binder: Binder:lab.

Also, the version of ITables developed in this PR can be installed with pip:

pip install git+https://github.com/mwouts/itables.git@update_style

(this requires nodejs, see more at Developing ITables)

@mwouts mwouts force-pushed the update_style branch 2 times, most recently from 9744f47 to 386e23c Compare June 19, 2024 20:13
@mwouts mwouts changed the title Use the same default parameters and style in Streamlit and notebooks Trigger an horizontal scroll through on overflow Jun 19, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.16%. Comparing base (d6a71c8) to head (6927453).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #282      +/-   ##
==========================================
- Coverage   96.16%   96.16%   -0.01%     
==========================================
  Files          27       27              
  Lines        1174     1173       -1     
==========================================
- Hits         1129     1128       -1     
  Misses         45       45              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mwouts mwouts merged commit c299b83 into main Jun 19, 2024
14 checks passed
@mwouts mwouts deleted the update_style branch June 19, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants