Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Load datatables with an ES import #60

Closed
wants to merge 2 commits into from

Conversation

mwouts
Copy link
Owner

@mwouts mwouts commented Feb 9, 2022

In this PR we switch to a pure ES import of datatables, cf. DataTables/DataTablesSrc#199

Closes #51

What remains:

@mwouts mwouts force-pushed the esm_only_version_using_datatables_nightly_build branch from 938d595 to 6415f30 Compare February 9, 2022 17:37
@codecov-commenter
Copy link

codecov-commenter commented Feb 9, 2022

Codecov Report

Merging #60 (6415f30) into main (f03c276) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #60   +/-   ##
=======================================
  Coverage   96.65%   96.65%           
=======================================
  Files          14       14           
  Lines         329      329           
=======================================
  Hits          318      318           
  Misses         11       11           
Impacted Files Coverage Δ
itables/javascript.py 96.58% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f03c276...6415f30. Read the comment docs.

@mwouts mwouts changed the title Esm only version using datatables nightly build WIP: Load datatables with an ES import Feb 9, 2022
@mwouts mwouts mentioned this pull request Apr 14, 2022
@mwouts
Copy link
Owner Author

mwouts commented Jun 17, 2022

Will do #76 instead

@mwouts mwouts closed this Jun 17, 2022
@mwouts mwouts deleted the esm_only_version_using_datatables_nightly_build branch June 17, 2022 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Load datatables.net using ESM in all cases
2 participants