Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension is given by the notebook metadata stdin notebooks #1284

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mwouts
Copy link
Owner

@mwouts mwouts commented Dec 7, 2024

Closes #1282

Copy link

github-actions bot commented Dec 7, 2024

Thank you for making this pull request.

Did you know? You can try it on Binder: Binder:lab or Binder:notebook.

Also, the version of Jupytext developed in this PR can be installed with pip:

HATCH_BUILD_HOOKS_ENABLE=true pip install git+https://github.com/mwouts/jupytext.git@take_extension_from_metadata_for_stdin_notebooks

(this requires nodejs, see more at Developing Jupytext)

@mwouts mwouts force-pushed the take_extension_from_metadata_for_stdin_notebooks branch from 61fda6a to 6e5ec72 Compare December 7, 2024 15:07
Copy link

codecov bot commented Dec 7, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.03%. Comparing base (b74f5ce) to head (6e5ec72).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/jupytext/formats.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1284      +/-   ##
==========================================
- Coverage   97.05%   97.03%   -0.03%     
==========================================
  Files          29       29              
  Lines        4479     4481       +2     
==========================================
+ Hits         4347     4348       +1     
- Misses        132      133       +1     
Flag Coverage Δ
external ?
functional ?
integration ?
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@goerz
Copy link

goerz commented Dec 8, 2024

Tested manually, and this works perfectly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update ipynb file with data from stdin fails
2 participants