fix(comments): hide empty placeholder if can't comment

Signed-off-by: Innei <tukon479@gmail.com>
mx-space · Apr 12, 2023 · eca5a8a · eca5a8a
1 parent 79cdbef
commit eca5a8a
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 12 deletions.
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/src/components/widgets/Comment/comments.tsx b/src/components/widgets/Comment/comments.tsx
@@ -40,14 +40,17 @@ import styles from './index.module.css'
 import { CommentAtRender } from './renderers/comment-at'
 
 type Id = string
-export const Comments: FC = memo(() => {
-  const comments = useCommentCollection((state) => state.comments)
-  if (comments.length === 0) {
-    return <Empty />
-  }
+export const Comments: FC<{ allowComment: boolean }> = memo(
+  ({ allowComment }) => {
+    const comments = useCommentCollection((state) => state.comments)
 
-  return createElement(CommentList)
-})
+    if (comments.length === 0) {
+      return allowComment ? <Empty /> : null
+    }
+
+    return createElement(CommentList)
+  },
+)
 
 const CommentList: FC = memo(() => {
   const comments = useCommentCollection((state) => state.comments)

diff --git a/src/components/widgets/Comment/index.tsx b/src/components/widgets/Comment/index.tsx
@@ -156,7 +156,7 @@ const CommentWrap: FC<CommentWrapProps> = (props) => {
       <span id="comment-anchor" />
       {commentShow ? (
         <Fragment>
-          <Comments />
+          <Comments allowComment={allowComment} />
           <div className="text-center">
             {pagination &&
               pagination.totalPage !== 0 &&