Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kami-design): image size #1534

Merged
merged 2 commits into from
Jan 11, 2023
Merged

Conversation

suemor233
Copy link
Member

fix #1533

@Innei
Copy link
Member

Innei commented Jan 10, 2023

这个有验证过吗。没有长宽的情况

@suemor233
Copy link
Member Author

suemor233 commented Jan 10, 2023

这个有验证过吗。没有长宽的情况

没有长宽的话应该会走 calculatedSize.height,也能正常显示

@Innei
Copy link
Member

Innei commented Jan 11, 2023

感觉这里有问题,还是需要验证下。当时透出修改图片尺寸是为了验证自动获取的尺寸是否正确。这个尺寸是为了在没有加载图片之前占位的。

@Innei
Copy link
Member

Innei commented Jan 11, 2023

需要验证以下 case:

  1. 没有长宽的
  2. 没有长的
  3. 没有宽的
  4. 长宽比例和原比例不一样的(> 1, <1)的

@suemor233
Copy link
Member Author

需要验证以下 case:

  1. 没有长宽的
  2. 没有长的
  3. 没有宽的
  4. 长宽比例和原比例不一样的(> 1, <1)的

都有测试过,没发现问题

@Innei Innei closed this Jan 11, 2023
@Innei Innei merged commit a6fe005 into mx-space:master Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

内容页图片显示问题
2 participants