Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a workspace input #80

Merged
merged 6 commits into from
Jul 2, 2022
Merged

Add a workspace input #80

merged 6 commits into from
Jul 2, 2022

Conversation

allisonmoyer
Copy link
Contributor

Problem Statement

Described in Issue #78

Proposed Solution

This change allows users to specify a workspace when invoking xcodebuild.

@mxcl
Copy link
Owner

mxcl commented May 3, 2022

Aaa, so if there's a workspace we don’t work? lol we suck.

K will merge and later make this automagic. @chris-araman pls approve.

@mxcl mxcl requested a review from chris-araman May 3, 2022 15:22
@mxcl
Copy link
Owner

mxcl commented May 3, 2022

Beautiful PR btw, it's so rare to get one (from new contributors) that is tight, not full of white space changes and easy to read.

@allisonmoyer
Copy link
Contributor Author

Beautiful PR btw, it's so rare to get one (from new contributors) that is tight, not full of white space changes and easy to read.

Thanks!

@mxcl
Copy link
Owner

mxcl commented May 4, 2022

Needs npm dist

@mxcl
Copy link
Owner

mxcl commented May 4, 2022

Odd CI didn't run… @chris-araman what happened

@mxcl mxcl force-pushed the add-workspace branch from 5b4d93a to ba8563a Compare July 2, 2022 11:23
@mxcl mxcl force-pushed the add-workspace branch 2 times, most recently from 590dffd to a95205d Compare July 2, 2022 11:56
@mxcl mxcl force-pushed the add-workspace branch from a95205d to aa3a0c6 Compare July 2, 2022 11:58
@mxcl mxcl merged commit ef2a64f into mxcl:master Jul 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants