Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update genai system attribute name to align with upstream #26

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

yiyuan-he
Copy link

Description of changes:
Updating gen_ai.system attribute key to better align with upstream Otel conventions.

Context: open-telemetry/semantic-conventions#1574 (comment)

Test plan:
Ran updated unit tests and new attribute value in spans from sample apps.
Screenshot 2024-12-16 at 3 40 35 PM
Screenshot 2024-12-16 at 3 39 26 PM

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@yiyuan-he yiyuan-he changed the base branch from v1_33_6_patch to v1_32_1_dev December 17, 2024 00:31
@yiyuan-he yiyuan-he changed the base branch from v1_32_1_dev to v1_33_6_patch December 17, 2024 00:31
@mxiamxia mxiamxia merged commit b6acced into mxiamxia:v1_33_6_patch Dec 17, 2024
37 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants