-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error while retrieving photos in wait.until(element_has_substring_or_substring((By.XPATH, "//body") #10
Comments
I'll fix it but I want to know, how is your internet connection ? Good or not ? How much mo/s ? Because I think 30 seconds timeout is amply sufficient.. |
@mxrch I have 100mbit cable, no issue with internet, set timeout to 300s and still fails, could it be due to large photo gallery? Data are incoming on 400KiB/s only (while reviews go 3.5 MiB/s). |
@mahdi1234 no it can't be that, if you have albums it will break the wait.
between these two lines at line 63 in lib/photos.py :
And upload the debug.html file somewhere & give the link or put it in a pastebin ? |
@mxrch here's the link https://upload.disroot.org/r/oz6AvU81#ZSCE6ceIJOCSkzi5Ad+LvFKj0m2uBTO/70YcSvCGglQ= will get self destruct on first download. |
Same error here. The only difference is mine says the error happened on line 86, but it's probably bc of the latest commits:
It only happens on target accounts on wich I get the |
I don't understand since in your debug.html @mahdi1234 you have one of the two "triggers" to detect if the page finished loading, on your file there is the string "reached the end" in the body, so it should not wait. |
@PinkDev1 @mahdi1234 I pushed a potential fix in the i10 branch (35173d0) can you checkout on it and tell me if it fixes the issue ? |
Welp, it doesn't crash anymore, so I guess it's a fix!
I've noted that you can view the albumarchive, but only when logged in with the target account. From any other account, it'll just throw a 404. I'll add a disclaimer for this, since even while having the target account's password this tool can provide plenty of automated insight. I'd also like to note that the cookies didn't change after I logged in to my spy account on another browser, outside my VM but on the same network. There's two possibilities:
So I'll add a disclaimer for this as well. Wait for my PR |
@PinkDev1 yes it happens sometimes, it's not happening with my emails list, but Sector035 had the same problem with his account. |
Don't hesitate to contact me on Twitter with your address email you are using GHunt with, I think I can't debug it but we never know |
That may be the case. I've tweaked a lot with the settings of my google accounts |
Update on this: It only happens when visiting the link directly, on a browser while logged-in with the target account. But on GHunt, even when authenticated with the target's google cookies, it says |
I just ran the tool and I'm getting the same crash . |
Well that's weird. Are you sure you downloaded the correct branch? |
@PinkDev1 I already merged the fix with the master branch ! |
@Adik69 can you show the output ? |
@PinkDev1 Can I have the Google ID you are trying with ? Don't worry I can't get the email from this |
UPDATE: I think I found the culprit: On account A I have tweaked my settings to harden my google account as much as possible. This account has almost all personalization disabled, and uses very few google services.
However, on account B the settings are pretty much default, and it's prob 8~ years old. This account uses many google services and has linked many accounts. Clicking on more information -> GHunt said:
It seems GHunt needs this setting to be turned on. I assume this setting has been turned on on accounts that have used Picasa, Picasa Web Albums, or the Picasa Web Albums API. My theory is that the images stored on Picasa were archived on the user's Google Photos, and then his account was automatically linked to Picasa in order to keep the service working. Therefor, GHunt will succeed on scrapping these account's albumarchive. It's probably extremely uncommon for a user to manually go (and somehow find) their albumarchive, and turn on that setting. See: https://support.google.com/picasa/answer/6383491 I haven't tested this myself bc AFAIK, there's no option to turn it off, and I don't want to expose my personal accounts. PS: No, I won't give you any google ID, I'm way too paranoid 😂 |
@mxrch I confirm it fixed the issue on two accounts I had it. |
Added back the Google Maps advisory Re-worded some stuff to make it more neutral Made hyper-link to issue mxrch#10
With b1a2a56
The text was updated successfully, but these errors were encountered: