Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JOSS Review] - testing fails due to incorrect dev instructions in README #1

Closed
ericfell opened this issue Oct 29, 2024 · 1 comment · Fixed by #8
Closed

[JOSS Review] - testing fails due to incorrect dev instructions in README #1

ericfell opened this issue Oct 29, 2024 · 1 comment · Fixed by #8

Comments

@ericfell
Copy link

Dear authors,

Given your current configuration of pyproject.toml, the clone and install process for development version fails when running pytest test/ because pyvisa isn't a required install.

The remedy is to change the README instruction #3 from pip install . to pip install .[dev].

This issue is related to openjournals/joss-reviews#7291
mxwalbert added a commit that referenced this issue Nov 18, 2024
@mxwalbert
docs: fix incorrect dev instructions in README (#1)
c42336d
@mxwalbert
Copy link
Owner

Dear @ericfell,
thank you for pointing out this issue. We changed the instructions according to your suggestion.

@mxwalbert mxwalbert linked a pull request Jan 3, 2025 that will close this issue
1 joss review #8
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

1-joss-review mxwalbert/cohesivm
1 joss review mxwalbert/cohesivm
2 participants
@ericfell @mxwalbert