Create & Fetch Experiment #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CreatCodeBuild
changed the title
CreatCodeBuild
force-pushed
the
CreateExperiment
branch
from
f37d7f3 to
910ffec
Compare
CreatCodeBuild
changed the title
magicoder10
requested changes
Nov 8, 2018
|
|
||
| func (store *FakeExperimentStore) FetchByOwner(id entity.ID) (exps []entity.Experiment) { | ||
| for _, e := range store.experiments { | ||
| if e.Owner == id { |
There was a problem hiding this comment.
Suggested change
| if e.Owner == id { | |
| if e.OwnerID == id { |
| return e | ||
| } | ||
|
|
||
| func (store *FakeExperimentStore) FetchByOwner(id entity.ID) (exps []entity.Experiment) { |
There was a problem hiding this comment.
Suggested change
| func (store *FakeExperimentStore) FetchByOwner(id entity.ID) (exps []entity.Experiment) { | |
| func (store *FakeExperimentStore) FetchByOwnerID(id entity.ID) (exps []entity.Experiment) { |
| type ExperimentStore interface { | ||
| Save(entity.Experiment) entity.Experiment | ||
| FetchByID(id entity.ID) entity.Experiment | ||
| FetchByOwner(ownerID entity.ID) []entity.Experiment |
There was a problem hiding this comment.
Suggested change
| FetchByOwner(ownerID entity.ID) []entity.Experiment | |
| FetchByOwnerID(ownerID entity.ID) []entity.Experiment |
| } | ||
|
|
||
| func (store *FakeExperimentStore) ErrNotFound() *adapter.ErrExperimentNotFound { | ||
| defer func() { |
There was a problem hiding this comment.
Could you please explain what are you doing here?
|
|
||
| type Experiment struct { | ||
| Model | ||
| Owner ID // todo: define User type |
There was a problem hiding this comment.
Suggested change
| Owner ID // todo: define User type | |
| OwnerID ID // todo: define User type |
| // This interface is for documentation only. | ||
| type experiment interface { | ||
| CreateExperiment(userID entity.ID) entity.Experiment | ||
| FetchByOwner(ownerID entity.ID) []entity.Experiment |
There was a problem hiding this comment.
Suggested change
| FetchByOwner(ownerID entity.ID) []entity.Experiment | |
| FetchByOwnerID(ownerID entity.ID) []entity.Experiment |
| return exp | ||
| } | ||
|
|
||
| func (e *Experiment) FetchByOwner(ownerID entity.ID) []entity.Experiment { |
There was a problem hiding this comment.
Suggested change
| func (e *Experiment) FetchByOwner(ownerID entity.ID) []entity.Experiment { | |
| func (e *Experiment) FetchByOwnerID(ownerID entity.ID) []entity.Experiment { |
| } | ||
|
|
||
| func (e *Experiment) CreateExperiment(userID entity.ID) entity.Experiment { | ||
| exp := e.store.Save(entity.Experiment{Owner: userID}) |
There was a problem hiding this comment.
Suggested change
| exp := e.store.Save(entity.Experiment{Owner: userID}) | |
| exp := e.store.Save(entity.Experiment{OwnerID: userID}) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #17
Please review this tomorrow.