Update self-update to support an optional version constraint #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We will be using pre-release tags for testing, which would be listed later than the latest tag
andytson-inviqa
force-pushed
the
feature/self-update-latest
branch
from
63a45de
to
519899c
Compare
andytson-inviqa
force-pushed
the
feature/self-update-constraint
branch
2 times, most recently
from
881601c
to
3682322
Compare
andytson-inviqa
commented
Feb 24, 2023
| private function getLatestReleaseByConstraint(string $targetConstraint): Release | ||
| { | ||
| try { | ||
| $releasesRaw = file_get_contents($this->apiUrl, false, $this->createStreamContext()); |
There was a problem hiding this comment.
the api's paginated as well, default 30 releases per page
andytson-inviqa
force-pushed
the
feature/self-update-constraint
branch
from
3682322
to
0175472
Compare
It will limit the release to the highest matching candidate based on a min stability default to stable
andytson-inviqa
force-pushed
the
feature/self-update-constraint
branch
from
0175472
to
5e82a0d
Compare
g-foster2020
previously approved these changes
Feb 27, 2023
andytson-inviqa
dismissed
g-foster2020’s stale review
The base branch was changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will limit the release to the highest matching candidate based on a min stability default to stable