useGeneratedKeys does work unexpected after upgrading from 3.4.4 to 3.5.6

[grobmeier]

MyBatis version

Upgrading from 3.4.4 to 3.5.6, Spring version 1.3.1 to 2.0.6.

Database vendor and version

MySQL: JDBC Driver 8.0.15 and also 8.0.22.

Test case or example project

This code:

    @Insert("INSERT INTO user SET activationkey =  #{activationkey}, email =  #{email} ")
    @Options(useGeneratedKeys = true, keyColumn = "id")
    void insertUser(User user);

runs as expected with 3.4.4 and with Spring 1.3.1.
But with 3.5.6 and Spring 2.0.6 the generated key is no longer added to the User object.

I know there was a breaking change around keyColumn, but that was always set like this.

[harawata]

Hello @grobmeier ,

Since 3.5.0, keyProperty is required.

Specifying keyProperty is now mandatory when using useGeneratedKeys. If you relied on the implicit default value (="id"), generated keys will be silently ignored. #1198

We have a list of backward incompatible changes in each release note.
https://github.com/mybatis/mybatis-3/releases/tag/mybatis-3.5.0
There usually aren't many, but 3.4.x -> 3.5.x was relatively a big change.

[grobmeier]

Oh, now I see. I mixed up keyColumn with keyProperty.

On this page
https://mybatis.org/mybatis-3/java-api.html
the docs say I should look for a difference between those two in the discussion above.

I got some better information on:
https://mybatis.org/mybatis-3/sqlmap-xml.html#insert_update_and_delete

I understand that keyProperty is the thing I need, but keyColumn is something specific which Postgres uses. Still, I am not absolutely sure on why I should use keyColumn at all.

However, since it is working I am grateful and close this issue - Thanks!