PropertyTokenizer causes Infinite Loop when used in enhanced for-loop

[sdcuike]

see titile

[harawata]

Any example or test case?
To fix a problem, we need to reproduce it first.
Thank you!

[sdcuike]

@Test
    public void test_PropertyTokenizer() {
        org.apache.ibatis.reflection.property.PropertyTokenizer tokenizer = new org.apache.ibatis.reflection.property.PropertyTokenizer("person[0].birthday.date");
        for (org.apache.ibatis.reflection.property.PropertyTokenizer propertyTokenizer : tokenizer) {
            System.out.println(propertyTokenizer);
        }
    }

will be Infinite Loop.

I do this:

package com.doctor.commons.core.reflection.property;

import java.util.Iterator;

import com.doctor.beaver.annotation.ThreadSafe;

/**
 *  
 * 
 * @author sdcuike
 *         <p>
 *         Created on 2016年10月24日
 *         <p>
 */
@ThreadSafe
public class PropertyTokenizer implements Iterable<PropertyTokenizer> {
    //person[0].birthday.date
    private String name;     //person
    private String indexName;//person[0]
    private String index;    //0
    private String children; //birthday.date

    public PropertyTokenizer(String fullName) {
        fullName = fullName.trim();
        int index = fullName.indexOf('.');
        if (index > -1) {
            name = fullName.substring(0, index);
            children = fullName.substring(index + 1);
        } else {
            name = fullName;
            children = null;
        }
        indexName = name;
        int indexOf = indexName.indexOf('[');
        if (indexOf > -1) {
            name = indexName.substring(0, indexOf);
            this.index = indexName.substring(indexOf + 1, indexName.length() - 1);
        }
    }

    @Override
    public Iterator<PropertyTokenizer> iterator() {
        return new PropertyTokenizerIterator();
    }

    @Override
    public String toString() {
        return "PropertyTokenizer [name=" + name + ", indexName=" + indexName + ", index=" + index + ", children=" + children + "]";
    }

    public String getName() {
        return name;
    }

    public String getIndexName() {
        return indexName;
    }

    public String getIndex() {
        return index;
    }

    public String getChildren() {
        return children;
    }

    public class PropertyTokenizerIterator implements Iterator<PropertyTokenizer> {
        private PropertyTokenizer current;

        @Override
        public boolean hasNext() {
            if (current != null) {
                return current.children != null;
            }
            return children != null;
        }

        @Override
        public PropertyTokenizer next() {
            if (current != null) {
                current = new PropertyTokenizer(current.children);
            } else {
                current = PropertyTokenizer.this;
            }
            return current;
        }

        @Override
        public void remove() {
            throw new UnsupportedOperationException();
        }

    }
}

test:

@Test
    public void testPropertyTokenizer() {
        PropertyTokenizer propertyTokenizer = new PropertyTokenizer("person[0].birthday.date");
        for (PropertyTokenizer propertyTokenizer2 : propertyTokenizer) {
            System.out.println(propertyTokenizer2);
        }

        Iterator<PropertyTokenizer> iterator = propertyTokenizer.iterator();
        while (iterator.hasNext()) {
            PropertyTokenizer propertyTokenizer2 = (PropertyTokenizer) iterator.next();
            System.out.println(propertyTokenizer2);

        }
    }

result:

PropertyTokenizer [name=person, indexName=person[0], index=0, children=birthday.date]
PropertyTokenizer [name=birthday, indexName=birthday, index=null, children=date]
PropertyTokenizer [name=date, indexName=date, index=null, children=null]
PropertyTokenizer [name=person, indexName=person[0], index=0, children=birthday.date]
PropertyTokenizer [name=birthday, indexName=birthday, index=null, children=date]
PropertyTokenizer [name=date, indexName=date, index=null, children=null]

[sdcuike]

mybatis source code not used by for-each loop,or while loop way.

[harawata]

I will remove Iterable from the super interface list as it's simpler.
Please use hasNext() and next() for iteration. It shouldn't be a big problem, right?

-public class PropertyTokenizer implements Iterable<PropertyTokenizer>, Iterator<PropertyTokenizer> {
+public class PropertyTokenizer implements Iterator<PropertyTokenizer> {

Thank you for the report!
Iwao

[sdcuike]

yes ，thanks for you answer