Change the default resultSetType to DEFAULT(same as unset) at annotation option #1344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thank you, @kazuki43zoo ! It looks good as it is, but how about adding null check to the builder? mappedStatement.resultSetType = resultSetType == null ? ResultSetType.DEFAULT : resultSetType;Then we may be able to omit null check from the statement handlers. |
kazuki43zoo
added a commit
to kazuki43zoo/mybatis-3
that referenced
this pull request
Sep 6, 2018
Member
Author
|
@harawata Thanks for your advice! |
kazuki43zoo
force-pushed
the
gh-1334_resultSetType
branch
from
ffaa58b to
788236f
Compare
kazuki43zoo
added a commit
to kazuki43zoo/mybatis-3
that referenced
this pull request
Sep 13, 2018
harawata
added a commit
to mybatis/mybatis.github.io
that referenced
this pull request
Dec 5, 2018
pulllock
pushed a commit
to pulllock/mybatis-3
that referenced
this pull request
Oct 19, 2023
pulllock
pushed a commit
to pulllock/mybatis-3
that referenced
this pull request
Oct 19, 2023
Change the default resultSetType to DEFAULT(same as unset) at annotation option
pulllock
pushed a commit
to pulllock/mybatis-3
that referenced
this pull request
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1334
I've added the
DEFAULTas new enum element. It become the same behavior with unset at xml mapper.