Skip to content

Conversation

@harawata
Copy link
Member

Jdbc3KeyGenerator silently ignores generated keys if keyProperty is missing.

if (keyProperties == null || keyProperties.length == 0) {
return;
}

It was not helpful already (e.g. #1183 ), but especially now that we fixed #1198 , users relying on the default 'keyProperty' value will experience an annoying problem with 3.5.0 i.e. assigning generated keys stops working without any error.
We should avoid it to happen.

@jeffgbutler @kazuki43zoo ,
Could you take a look and see if I am missing something, please?

@harawata harawata added the enhancement Improve a feature or add a new feature label Jan 20, 2019
@harawata harawata added this to the 3.5.0 milestone Jan 20, 2019
@harawata harawata self-assigned this Jan 20, 2019
@harawata
Copy link
Member Author

I forgot about the PostgreSQL's funky behavior. :P
Let's hope everyone reads the release note carefully.

@harawata harawata closed this Jan 20, 2019
@harawata harawata removed their assignment Jan 20, 2019
@harawata harawata removed the enhancement Improve a feature or add a new feature label Jan 20, 2019
@harawata harawata removed this from the 3.5.0 milestone Jan 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant