Throw exception when 'keyProperty' is missing in Jdbc3KeyGenerator. #1453
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jdbc3KeyGeneratorsilently ignores generated keys ifkeyPropertyis missing.mybatis-3/src/main/java/org/apache/ibatis/executor/keygen/Jdbc3KeyGenerator.java
Lines 63 to 65 in 87c6e79
It was not helpful already (e.g. #1183 ), but especially now that we fixed #1198 , users relying on the default 'keyProperty' value will experience an annoying problem with 3.5.0 i.e. assigning generated keys stops working without any error.
We should avoid it to happen.
@jeffgbutler @kazuki43zoo ,
Could you take a look and see if I am missing something, please?