Skip to content

Ambiguous collection type bug fix. Ref #364 #1472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
harawata merged 1 commit into from
Jan 30, 2019
Merged

Ambiguous collection type bug fix. Ref #364 #1472

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/org/apache/ibatis/builder/xml/XMLMapperBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,12 +413,12 @@ private String processNestedResultMappings(XNode context, List<ResultMapping> re

protected void validateCollection(XNode context, Class<?> enclosingType) {
if ("collection".equals(context.getName()) && context.getStringAttribute("resultMap") == null
&& context.getStringAttribute("resultType") == null) {
&& context.getStringAttribute("javaType") == null) {
MetaClass metaResultType = MetaClass.forClass(enclosingType, configuration.getReflectorFactory());
String property = context.getStringAttribute("property");
if (!metaResultType.hasSetter(property)) {
throw new BuilderException(
"Ambiguous collection type for property '" + property + "'. You must specify 'resultType' or 'resultMap'.");
"Ambiguous collection type for property '" + property + "'. You must specify 'javaType' or 'resultMap'.");
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/org/apache/ibatis/submitted/stringlist/StringListTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ void shouldFailFastIfCollectionTypeIsAmbiguous() throws Exception {
fail("Should throw exception when collection type is unresolvable.");
} catch (PersistenceException e) {
assertTrue(e.getMessage()
.contains("Ambiguous collection type for property 'groups'. You must specify 'resultType' or 'resultMap'."));
.contains("Ambiguous collection type for property 'groups'. You must specify 'javaType' or 'resultMap'."));
}
}
}