Support to assign single primitive parameter on SQL provider method #1604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harawata
reviewed
Jul 13, 2019
src/main/java/org/apache/ibatis/builder/annotation/ProviderSqlSource.java
Show resolved
Hide resolved
harawata
reviewed
Jul 13, 2019
src/main/java/org/apache/ibatis/builder/annotation/ProviderSqlSource.java
Show resolved
Hide resolved
harawata
approved these changes
Jul 13, 2019
kazuki43zoo
added a commit
to kazuki43zoo/mybatis-3
that referenced
this pull request
Jul 14, 2019
kazuki43zoo
added a commit
to kazuki43zoo/mybatis-3
that referenced
this pull request
Jul 14, 2019
kazuki43zoo
added a commit
to kazuki43zoo/mybatis-3
that referenced
this pull request
Jul 14, 2019
kazuki43zoo
added a commit
that referenced
this pull request
Jul 15, 2019
…-compatibility Fix broken backward compatibility by gh-1604
pulllock
pushed a commit
to pulllock/mybatis-3
that referenced
this pull request
Oct 19, 2023
Support to assign single primitive parameter on SQL provider method
pulllock
pushed a commit
to pulllock/mybatis-3
that referenced
this pull request
Oct 19, 2023
pulllock
pushed a commit
to pulllock/mybatis-3
that referenced
this pull request
Oct 19, 2023
…roken-backward-compatibility Fix broken backward compatibility by mybatisgh-1604
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation cannot use primitive type on SQL provider method. For details, see gh-1595.
I've fixed gh-1595 using based on solution that suggested by @harawata (See #1595 (comment)), however I've changed some implementations from suggested implementation by @harawata for keeping backward compatibility with 3.5.1 as follows:
instanceof(ParamMap->Map)ProviderContextandMap@harawata WDYT?