Add columnPrefix to @One and @Many #1829
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harawata
requested changes
Feb 11, 2020
Member
harawata
left a comment
harawata
left a comment
There was a problem hiding this comment.
Mostly looks good! Thank you, @moonService !
There are two copyrighted files. Could you remove those headers?
src/test/java/org/apache/ibatis/submitted/annotion_many_one_add_columnprefix/RoleDao.xml
Outdated
Show resolved
Hide resolved
src/test/java/org/apache/ibatis/submitted/annotion_many_one_add_columnprefix/SqlMapConfig.xml
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@harawata please check it if you have time |
Member
|
Thanks for the update, @moonService ! |
- Removed a wrong import. - Column size should be large enough to contain the test data. - Renamed role_name/roleName to name This is not an issue, but it unnecessarily makes the test harder to understand.
harawata
approved these changes
Feb 14, 2020
harawata
changed the title
Member
|
@moonService , |
kazuki43zoo
added a commit
that referenced
this pull request
Mar 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.