Skip to content

Conversation

@kazuki43zoo
Copy link
Member

  • modify to use Cursor.class.isAssignableFrom(Class<?>)
  • modfiy to use ExceptionFactory.wrapException(String,Exception)
  • modify copyright year

Please review #437 polishing.

* modify to use Cursor.class.isAssignableFrom(Class<?>)
* modfiy to use ExceptionFactory.wrapException(String,Exception)
* modify copyright year
emacarron added a commit that referenced this pull request Jul 12, 2015
@emacarron emacarron merged commit 66b3a46 into mybatis:master Jul 12, 2015
@gdarmont
Copy link
Contributor

@kazuki43zoo
Cursor.class.isAssignableFrom(Class<?>) is broken.
If we have a "SubCursor" interface that extends "Cursor", Cursor.class.isAssignableFrom(SubCursor.class) returns true. But the implementation returned will always be a DefaultCursor, which is not a SubCursor. This will trigger ClassCastException.

As a side note, adding yourself to the authors list for only one line changed (MapperMethod) seems rather weird to me. But I leave this considerations to the projects maintainers.

@emacarron
Copy link
Member

Hi guys,

@gdarmont being strict it is OK that you add your name to the author list for any trivial change you make given that you are indeed the author of the change. It is up to the contributor to add himself though we do not see often that behaviour.

I will revert the change until the isAssignableFor issue is clarified.

Anyway please, remember this is the right way. Any contribution is welcomed and discussion is also welcomed so thanks both for your work!

@kazuki43zoo kazuki43zoo deleted the issues/437_polishing branch August 10, 2015 14:55
pulllock pushed a commit to pulllock/mybatis-3 that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants