Skip to content

Correct typo in JdbcTransaction.java (autoCommmit -> autoCommit) #941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kazuki43zoo merged 3 commits into from
Mar 17, 2018
Merged

Correct typo in JdbcTransaction.java (autoCommmit -> autoCommit) #941

kazuki43zoo merged 3 commits into from
Mar 17, 2018

Conversation

@luoxn28
Copy link
Contributor

@luoxn28 luoxn28 commented Mar 3, 2017

update a variable name in JdbcTransaction class.

@luoxn28
Update JdbcTransaction.java
4a2bf46 
update a variable name in JdbcTransaction class.
@kazuki43zoo
Copy link
Member

kazuki43zoo commented Mar 3, 2017

@luoxn28 Thank for your contribution.
However we can't merge yet. See #770.

@kazuki43zoo kazuki43zoo added this to the 3.5.0 milestone Mar 3, 2017
@hazendaz
Copy link
Member

hazendaz commented May 24, 2017

@kazuki43zoo @harawata Do we really think this breaks something?

@harawata
Copy link
Member

harawata commented May 24, 2017

@hazendaz
I am not sure. I could find only one use case that may be affected.
As it should not be too hard to fix, I am OK if you want to fix this in 3.4.x line.

@kazuki43zoo
Copy link
Member

kazuki43zoo commented May 24, 2017

Hi @hazendaz ,
I think impact of this change is very small. However I prefer to keep a backward compatibility in maintenance version release as possible as.

@harawata harawata mentioned this pull request Jul 4, 2017
Closed
@harawata harawata changed the title Update JdbcTransaction.java Correct typo in JdbcTransaction.java (autoCommmit -> autoCommit) Jul 4, 2017
@harawata harawata mentioned this pull request Jul 4, 2017
Closed
harawata added a commit that referenced this pull request Jul 4, 2017
@harawata
refs #941 Added a note on the popular typo. [ci skip]
3fc1758
@kazuki43zoo
Copy link
Member

kazuki43zoo commented Mar 16, 2018

@harawata Is this change apply on 3.5.0 ? or @Deprecated (3.5.0) -> remove future version(e.g. 4,0,0)?

@harawata
Copy link
Member

harawata commented Mar 16, 2018

@kazuki43zoo Let's just change it in 3.5.0. =D

@kazuki43zoo
Copy link
Member

kazuki43zoo commented Mar 16, 2018

OK!!

@kazuki43zoo kazuki43zoo added the no backward compatibility Includes change no backward compatibility for previous version label Mar 16, 2018
@kazuki43zoo kazuki43zoo merged commit cd2daad into mybatis:master Mar 17, 2018
@kazuki43zoo
Copy link
Member

kazuki43zoo commented Mar 17, 2018 •
edited
Loading

@luoxn28 Thanks for your contribution. I've merged now!

@kazuki43zoo kazuki43zoo self-assigned this Mar 17, 2018
pulllock pushed a commit to pulllock/mybatis-3 that referenced this pull request Oct 19, 2023
@harawata
refs mybatis#941 Added a note on the popular typo. [ci skip]
e7659df
pulllock pushed a commit to pulllock/mybatis-3 that referenced this pull request Oct 19, 2023
@kazuki43zoo
Merge pull request mybatis#941 from luoxn28/master
735f8fd 
Correct typo in JdbcTransaction.java (autoCommmit -> autoCommit)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@kazuki43zoo kazuki43zoo

Labels

no backward compatibility Includes change no backward compatibility for previous version

Projects

None yet

Milestone

3.5.0

Development

Successfully merging this pull request may close these issues.

4 participants

@luoxn28 @kazuki43zoo @hazendaz @harawata