Fixes incomplete PR #947. #976
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o a new instance of the type handler that takes the enum type as a constructor argument.
Member
|
@harawata It seem good !! 👍 |
kazuki43zoo
reviewed
Apr 14, 2017
Member
kazuki43zoo
left a comment
kazuki43zoo
left a comment
There was a problem hiding this comment.
I've added one comment.
Please check it.
| HashMap<JdbcType, TypeHandler<?>> newMap = new HashMap<JdbcType, TypeHandler<?>>(); | ||
| for (Entry<JdbcType, TypeHandler<?>> entry : jdbcHandlerMap.entrySet()) { | ||
| // Create a type handler instance with enum type as a constructor arg | ||
| newMap.put(entry.getKey(), getInstance(enumClazz, entry.getValue().getClass())); |
Member
There was a problem hiding this comment.
I think that it is better to register the creating type handler in association with Enum type for performance. What do you think ?
Member
There was a problem hiding this comment.
I withdraw above comment because it work fine in current implementation.
Member
Author
There was a problem hiding this comment.
OK. Let's merge this and see how it works!
harawata
added
bug
and removed
enhancement
pulllock
pushed a commit
to pulllock/mybatis-3
that referenced
this pull request
Oct 19, 2023
…erface-take2 Proper fix for mybatis#947 . When there is a type handler registered to a super interface of an enum, new instance of the type handler should be created with the enum type as a constructor argument.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #947 didn't work as expected. An enum type handler needs to take enum type as constructor argument.