-
Notifications
You must be signed in to change notification settings - Fork 212
Add a Kotlin DSL #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add a Kotlin DSL #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: .gitignore
This enables a more Kotlin friendly syntax
This resolves some issues with idiomatic Kotlin with no loss of function to the basic library. We can now use a Kotlin function with receiver to repeatedly call methods on the QueryExpressionDSL without causing a duplicate expression to be added to the query.
Basically, delay creating the paging model until the entire select model is built. This does not change the paging experience for the base library, but makes the paging experience more compatible with Kotlin. We can now use a receiver function for the paging operation.
Conflicts: src/main/java/org/mybatis/dynamic/sql/select/QueryExpressionDSL.java src/main/java/org/mybatis/dynamic/sql/select/SelectDSL.java
Conflicts: src/main/java/org/mybatis/dynamic/sql/select/QueryExpressionDSL.java src/test/java/examples/simple/PersonWithAddressMapper.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a set of Kotlin extensions that support an idiomatic Kotlin DSL. Included are full examples and documentation for using the Kotlin DSL with MyBatis3.
Several minor changes were made to the underlying Java code to support Kotlin, but non caused an issue with the existing function of the library.
Also added is a new CountDSL - a specialization of a select statement that supports joins and a where clause, but no other parts of a select statement. This will be used by MyBatis Generator and the canonical Kotlin mapper.
Squash the commits in this PR when merging!