Implement Callback for In and NotIn Conditions When the Value List is Empty #241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The case insensitive in conditions are actually specializations of the regular in conditions and not intended to be extended.
# Conflicts: # src/main/java/org/mybatis/dynamic/sql/AbstractListValueCondition.java # src/main/java/org/mybatis/dynamic/sql/where/condition/IsIn.java # src/main/java/org/mybatis/dynamic/sql/where/condition/IsInCaseInsensitive.java # src/main/java/org/mybatis/dynamic/sql/where/condition/IsNotInCaseInsensitive.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the "In" and "NotIn" conditions, when the value list is empty the library will drop the condition from the rendered SQL. This keeps the library from rendering invalid SQL.
This PS implements a new callback that provides an extension point where a user could take an action - such as throwing an exception - if the list is empty.
This PR also removes the option that would force the library to render invalid SQL introduced with #228