ClassPathMapperScanner scan mappers interface do not check if it contains @Mapper annotation

[maxjiang153]

when scan interfaces it will proxy all interface even it does not contains @Mapper interface.

https://github.com/mybatis/spring/blob/master/src/main/java/org/mybatis/spring/mapper/ClassPathMapperScanner.java#L216

  protected boolean isCandidateComponent(AnnotatedBeanDefinition beanDefinition) {
    return beanDefinition.getMetadata().isInterface() && beanDefinition.getMetadata().isIndependent();
  }


  should be check has @Mapper annotation like this?
  protected boolean isCandidateComponent(AnnotatedBeanDefinition beanDefinition) {
    return beanDefinition.getMetadata().isInterface() && beanDefinition.getMetadata().isIndependent() 
                    &&  beanDefinition.getMetadata().hasAnnotation(Mapper.class.getName()); 
  }

example :

interface Example {
....
}

will create MapperFactoryBean proxy without @Mapper

[kazuki43zoo]

Probably you can scan only interfaces that annotated the @Mapper invoking ClassPathMapperScanner.setAnnotationClass(Mapper.class) .

The @Mapper has been added as the optional annotation for narrowing down target interfaces on DI container like CDI or Spring's ApplicationContext.
For details see mybatis/mybatis-3#629.

Note:
This annotation is used the MybatisAutoConfiguration provided by mybatis-spring-boot-starter.

[kazuki43zoo]

For example:

<mybatis:scan base-package="com.example" annotation="org.apache.ibatis.annotations.Mapper" />

or

@MapperScan(basePackages = "com.example", annotationClass = Mapper.class)
public class MyBatisConfig {
  // ...
}

[maxjiang153]

@kazuki43zoo thanks : )